Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs for network-cmd-path #24104

Merged
merged 1 commit into from
Sep 30, 2024
Merged

update docs for network-cmd-path #24104

merged 1 commit into from
Sep 30, 2024

Conversation

Sativarsainath-26
Copy link
Contributor

@Sativarsainath-26 Sativarsainath-26 commented Sep 29, 2024 •
edited by Luap99
Loading

Fixes: #23711

Does this PR introduce a user-facing change?

None

@Luap99
Copy link
Member

Luap99 commented Sep 30, 2024

Thanks for the PR but this option cannot be removed as stated in #23711 (comment) this will break any user still using it and we can only do breaking changes for major releases.

I suggest you simply update the docs and code comment.

@Sativarsainath-26
adding docs for network-cmd-path
e07c310 
Signed-off-by: Sainath Sativar <[email protected]>
@Sativarsainath-26
Copy link
Contributor Author

Thanks for the PR but this option cannot be removed as stated in #23711 (comment) this will break any user still using it and we can only do breaking changes for major releases.

I suggest you simply update the docs and code comment.

Sure @Luap99 , I have updated it to reflect that the change will be implemented in Podman 6.0, the next major version. Hope this is okay.

@Luap99 Luap99 added the No New Tests Allow PR to proceed without adding regression tests label Sep 30, 2024
@Luap99 Luap99 changed the title removing network-cmd-path option from podman update docs for network-cmd-path Sep 30, 2024
Luap99
Luap99 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, Sativarsainath-26

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
@Sativarsainath-26
Copy link
Contributor Author

@Luap99 could you please help here to fix this pipeline failure ? Not sure why it is failing... as i didn't touch that part of code only.

@baude
Copy link
Member

baude commented Sep 30, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 639f3c6 into containers:main Sep 30, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luap99 Luap99 Luap99 approved these changes

Assignees

@baude baude

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option --network-cmd-path was not removed in Podman 5.0
3 participants
@Sativarsainath-26 @Luap99 @baude